Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pubcommon optout from user id module checks #5994

Merged
merged 1 commit into from
Nov 30, 2020
Merged

remove pubcommon optout from user id module checks #5994

merged 1 commit into from
Nov 30, 2020
+9 −13

Conversation

smenzer
Copy link
Collaborator

@smenzer smenzer commented Nov 17, 2020

Per #5991, there's no reason to include checks for pub common's opt out when running the optout checks for the entire user id module

@smenzer smenzer linked an issue Nov 17, 2020 that may be closed by this pull request
Why is pubcommon optout blocking entire User ID Module? #5991
Closed
@harpere harpere requested a review from jlukas79 November 21, 2020 06:42
@harpere harpere merged commit 57ef24a into master Nov 30, 2020
@harpere harpere deleted the remove-pubcommon-optout-from-userid-core-module branch November 30, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harpere harpere harpere approved these changes

@jlukas79 jlukas79 Awaiting requested review from jlukas79

Assignees

@jlukas79 jlukas79

Labels
maintenance needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is pubcommon optout blocking entire User ID Module?
3 participants
@smenzer @harpere @jlukas79